saltstack-formulas / postfix-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
25 stars 130 forks source link

test(default): add inspec for base and maps #108

Closed fzipi closed 4 years ago

fzipi commented 4 years ago

Signed-off-by: Felipe Zipitria fzipitria@perceptyx.com

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 0.73

Best reviewed: commit by commit


Optimal code review plan (1 warning)

test(default): add inspec for base and maps
> `test/salt/pillar/postgrey.sls` 68% changes removed in fix(deps): fixes ord...
     fix(test): use specific ip to workaround centos bug      fix(deps): fixes ordering where postmap requires sane main.cf

Powered by Pull Assistant. Last update 2a61498 ... a28bd05. Read the comment docs.

fzipi commented 4 years ago

Ready to merge!

myii commented 4 years ago

@fzipi Looks really detailed -- kudos!

Where does the test/salt/pillar/postgrey.sls pillar get used? Does that need to be added to kitchen.yml?

fzipi commented 4 years ago

:thinking: two tests slipped: postgrey and mysql. I'm removing the mysql test (that does nothing yet), and will push those next.

myii commented 4 years ago

Nice work, @fzipi -- merged.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.0.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: