run postmap also for regexp maps

hoonetorg commented 4 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[x] [feat] A new feature
[x] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Run postmap also for regexp style maps

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan

feat(config): run postmap also for regexp maps

Powered by Pull Assistant. Last update 7584fce ... 7584fce. Read the comment docs.

myii commented 4 years ago

Thanks for the PR, @hoonetorg. Please see the contributing guidelines for how to format commit messages for our formulas. As an example, the new message may be something like:

-run postmap also for regexp maps
+feat(config): run postmap also for regexp maps

Ideally, just amend the commit message and then force push back to the branch you've used for this PR.

Hopefully, @fzipi will be able to review and merge this PR after that.

fzipi commented 4 years ago

We should think about having tests for each different file type in the future.

myii commented 4 years ago

@fzipi Care to merge? I prefer to leave it to code owners where we have those set!

myii commented 4 years ago

We should think about having tests for each different file type in the future.

That's an excellent idea.

hoonetorg commented 4 years ago

Thx for quick merging. I agree on writing more granular tests. Keep up with the good work.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / postfix-formula