saltstack-formulas / postfix-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
25 stars 130 forks source link

feat(maps): add more map types and tests #114

Closed fzipi closed 4 years ago

fzipi commented 4 years ago

Signed-off-by: Felipe Zipitria fzipitria@perceptyx.com

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Adds pcre and cidr maps and their tests. Also add tests for regexp map type.

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Tests are provieded in pillars.

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     feat(maps): add more map types and tests

Powered by Pull Assistant. Last update e3970df ... e3970df. Read the comment docs.

myii commented 4 years ago

I second @daks, excellent work here @fzipi! Thanks to you both here.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: