Closed tacerus closed 1 year ago
The Gentoo CI shows some error about sudoers, I don't think it's related to my changes?
@myii Do you know why pipelines are failing on Gitlab?
@tacerus Maybe you can fix these ones from rubocop? https://github.com/saltstack-formulas/postfix-formula/pull/127/checks?check_run_id=10857620099
Thanks @fzipi, I somehow completely missed that the current version of the formula already supports the option I (re-)implemented. I'll soon revisit this PR to see if it adds any value, otherwise I will close it.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
smtp_tls_wrappermode
configuration optionPillar / config required to test the proposed changes
The existing
smtpd_tls_true
behavior did not change, so this will work just as well:Debug log showing how the proposed changes work
Output
``` [DEBUG ] Results of YAML rendering: OrderedDict([('salt', OrderedDict([('clean_config_d_dir', False), ('minion_remove_config', True), ('minion', OrderedDict([('master_type', 'str')]))]))]) [PROFILE ] Time (in seconds) to render '/srv/pillar/role/salt/minion.sls' using 'yaml' renderer: 0.0011065006256103516 [DEBUG ] compile template: /srv/pillar/common/suse.sls [DEBUG ] Jinja search path: ['/srv/pillar', '/srv/spm/pillar'] [PROFILE ] Time (in seconds) to render '/srv/pillar/common/suse.sls' using 'jinja' renderer: 0.0007901191711425781 [DEBUG ] Rendered data from file: /srv/pillar/common/suse.sls: include: - .postfix zypper: refreshdb_force: False [DEBUG ] Results of YAML rendering: OrderedDict([('include', ['.postfix']), ('zypper', OrderedDict([('refreshdb_force', False)]))]) [PROFILE ] Time (in seconds) to render '/srv/pillar/common/suse.sls' using 'yaml' renderer: 0.0009088516235351562 [DEBUG ] compile template: /srv/pillar/common/postfix.sls [DEBUG ] Jinja search path: ['/srv/pillar', '/srv/spm/pillar'] [PROFILE ] Time (in seconds) to render '/srv/pillar/common/postfix.sls' using 'jinja' renderer: 0.0018353462219238281 [DEBUG ] Rendered data from file: /srv/pillar/common/postfix.sls: postfix: master_config: services: smtp: enable: False tlsproxy: enable: True config: # to-do: set via site config relayhost: zz0.email myhostname: bd5de19d49b1 inet_interfaces: loopback-only # to-do: support relay via IPv6 inet_protocols: ipv4 alias_maps: lmdb:/etc/aliases smtpd_use_tls: 'no' smtp_use_tls: 'yes' smtp_tls_security_level: encrypt smtp_tls_wrappermode: 'yes' [DEBUG ] Results of YAML rendering: OrderedDict([('salt', OrderedDict([('master', OrderedDict([('syndic_user', 'salt'), ('syndic_master', "${'secret_salt:master:syndic_master'}")]))]))]) [PROFILE ] Time (in seconds) to render '/srv/pillar/role/salt/syndic.sls' using 'yaml' renderer: 0.0009541511535644531 [DEBUG ] Skipping ignored and missing SLS 'role.lighttpd' in environment 'base' [DEBUG ] Skipping ignored and missing SLS 'role.matterbridge' in environment 'base' [DEBUG ] LazyLoaded jinja.render [DEBUG ] LazyLoaded yaml.render [DEBUG ] LazyLoaded state.apply [DEBUG ] LazyLoaded direct_call.execute [DEBUG ] LazyLoaded saltutil.is_running [DEBUG ] Override __grains__:Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context