saltstack-formulas / postfix-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
25 stars 130 forks source link

Improve handling of multiple values in main.cf #77

Closed ixs closed 5 years ago

ixs commented 5 years ago

In case a list of items (iterable) is passed to the set_parameter function in main.cf, the list of items are joined by a comma.

This makes parameters with many items a bit hard to read as it results in long lines.

Postfix also supports an alternative declaration where subsequent parameter values are written in a new line that starts with whitespace and thus forms a continuation of the previous line. This makes parsing multiple entry lines easier for humans.

Old style:

smtpd_milters = { unix:/run/spamass-milter/postfix/sock, connect_timeout=10s, default_action=accept } { inet:localhost:10003, connect_timeout=10s, default_action=accept } { inet:localhost:10004, connect_timeout=10s, default_action=accept } { inet:localhost:10006, connect_timeout=10s, default_action=accept } { inet:localhost:10007, connect_timeout=10s, default_action=accept }

New style:

smtpd_milters = { unix:/run/spamass-milter/postfix/sock, connect_timeout=10s, default_action=accept }
                { inet:localhost:10003, connect_timeout=10s, default_action=accept }
                { inet:localhost:10004, connect_timeout=10s, default_action=accept }
                { inet:localhost:10006, connect_timeout=10s, default_action=accept }
                { inet:localhost:10007, connect_timeout=10s, default_action=accept }
javierbertoli commented 5 years ago

Thanks @ixs! Nice improvement! :smile: