search

saltstack-formulas / prometheus-formula

Manage a Prometheus installation
Other
27 stars 51 forks source link

feat(macos): basic package and group handling #2

Closed noelmcloughlin closed 5 years ago

noelmcloughlin commented 5 years ago

PR adding basic package & group handling (see https://github.com/saltstack/salt/issues/53325) on MacOS.

myii commented 5 years ago

@noelmcloughlin You may be interested in a tiny refactor I added to this change in the template-formula. The potential mix-up with the *BSDs needed to be avoided, I felt.

noelmcloughlin commented 5 years ago

Let's discuss this at your PR.

myii commented 5 years ago

My comment there is just as significant here!

noelmcloughlin commented 5 years ago

Resolves #1

noelmcloughlin commented 5 years ago

Hi @myii I have updated PR to align with template-formula. thanks

myii commented 5 years ago

Thanks @noelmcloughlin. I thought it would be good to wait for a review from @alxwr since he's the rootgroup expert!

noelmcloughlin commented 5 years ago

Hi @alxwr could you review please when you get time.

Sorry ,I did'nt have permission to add reviewers to this and the grafana PR.

myii commented 5 years ago

@noelmcloughlin Actually, we can't select reviewers (or even merge) until write access is enabled on this repo. I've made a request on Slack, so it should be done soon.

noelmcloughlin commented 5 years ago

Aah yeah, no merge button!!! he he.

myii commented 5 years ago

@noelmcloughlin Done (and requested grafana-formula as well).

noelmcloughlin commented 5 years ago

thanks @aboe and @myii

alxwr commented 5 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

myii commented 5 years ago

@alxwr I didn't realise you've become the semantic-release bot! Don't worry, I've just modified the Travis settings to give the permissions to the real bot. We shouldn't have this problem going forward.