fix(debian): add some valid defaults

javierbertoli commented 4 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[X] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

This should probably fix #42. Debian's family names have the format prometheus-component-{exporter} and the systemd' services path is not the one set in the defaults.

Describe the changes you're proposing

Added a bunch of entries to manage some services and default files correctly for the Debian family.

Quite possibly, this can be better fixed in the map.jinja file in an automated way (add 'prometheus' to the packages names, replace underscores with dashes, etc.)

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan (2 warnings)

fix(debian): add some valid defaults

test(services): fix path for debian family

> `...fault/controls/archive_spec.rb` 82% changes removed in fix(archive): add co...

fix(archive): service name needs to use pillar values

> `prometheus/archive/install.sls` 50% changes removed in fix(archive): add co...

test(archive): add tests to check service names fix(archive): add config file to service only if defined

Powered by Pull Assistant. Last update 844a77f ... a5b44c8. Read the comment docs.

n-rodriguez commented 4 years ago

@javierbertoli can you fix and rebase please? :)

javierbertoli commented 4 years ago

@javierbertoli can you fix and rebase please? :)

working on that :yum:

n-rodriguez commented 4 years ago

@javierbertoli can we merge?

javierbertoli commented 4 years ago

@n-rodriguez if you are OK with the PR, yes. Just don't want to do a "self-merge", so if you, @myii or @noelmcloughlin can do it, it'd be great.

n-rodriguez commented 4 years ago

@javierbertoli I'm testing your branch on my side. I'll merge it if everything is ok.

javierbertoli commented 4 years ago

Perfect! let me know if you find something else I should change or that I missed! Thanks!

n-rodriguez commented 4 years ago

@javierbertoli thank you!

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 5.0.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / prometheus-formula