Manage unofficial exporters

[lagooj]

PR progress checklist (to be filled in by reviewers)

• [ ] Changes to documentation are appropriate (or tick if not required)
• [ ] Changes to tests are appropriate (or tick if not required)
• [ ] Reviews completed

---

What type of PR is this?

Support "unofficial" exporter with archive as upstream

Primary type

• [ ] [build] Changes related to the build system
• [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ ] [ci] Changes to the continuous integration configuration
• [X] [feat] A new feature
• [ ] [fix] A bug fix
• [ ] [perf] A code change that improves performance
• [ ] [refactor] A code change that neither fixes a bug nor adds a feature
• [ ] [revert] A change used to revert a previous commit
• [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [ ] [docs] Documentation changes
• [X] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Taking care of "unofficial exporter" as postgresql, php-fpm ...

Pillar / config required to test the proposed changes

Under pkg:component:name:archive adding official: true/false ( default => true) tar: true/false ( default => true)

Debug log showing how the proposed changes work

Documentation checklist

• [ ] Updated the README (e.g. Available states).
• [X] Updated pillar.example.

Testing checklist

• [ ] Included in Kitchen (i.e. under state_top).
• [X] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• [X] Updated the relevant test pillar.

Additional context

[lagooj]

LGTM mostly. I also need this feature. I am not sure tar: boolean is needed because the archive dict is always an archive. So file.managed will work for both official and unofficial exporters. There is probably no need to introduce archive.extracted as well since file.managed handles archives too? Just check the extra code is actually needed.

Hi, I kept the original mechanism, to be sure to break nothing, as it's kind of trivial modification. Not all opensource exporter deliver an archive, some as php-fpm provide only binary file, that's why I implemented tar: bool, in order to be able to switch to file managed if needed. archive.extracted, extracts on fly, I didn't find the same behavior for file.managed in salt documentation, but I could be wrong :)

[noelmcloughlin]

Get Travis CI passing and I'll merge. thanks @lagooj

[saltstack-formulas-travis]

:tada: This PR is included in version 5.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: