saltstack-formulas / prometheus-formula

Manage a Prometheus installation
Other
27 stars 51 forks source link

fix(users): users should always be created as system users #72

Closed mdschmitt closed 2 years ago

mdschmitt commented 2 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

Yes. If users already exist and this formula tries to mandate that they be system users, I think it'll try to change their existing uid, which is bad or should fail or both.

Related issues and/or pull requests

Fixes #70

Describe the changes you're proposing

All users created by this formula are expected to be users that run exporters or prometheus itself. All should be system users, not added with regular user uids.

Pillar / config required to test the proposed changes

N/A

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

saltstack-formulas-travis commented 2 years ago

:tada: This PR is included in version 5.6.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: