search

saltstack-formulas / redis-formula

Redis state
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
40 stars 186 forks source link

Support for sentinel setup with redis for HA #65

Closed arthurzenika closed 6 years ago

arthurzenika commented 7 years ago

Hi,

Any plans to add support for redis with sentinel to have a high availability redis cluster ? Or should this be in a separate formula ?

johnkeates commented 7 years ago

It should be built into this one, but I don't think there is a product owner for this formula that will implement features on demand. But do feel free to add it and make a PR, and we'll merge it!

arthurzenika commented 7 years ago

@johnkeates thanks for you answer, if our need for sentinel with saltstack is confirmed, we will make sure to contribute back to the formula.

A quick search got me to https://github.com/zulily/redis-sentinel-formula which I haven't tried yet, it might be useful to merge or at least collaborate with @bhodges

arthurzenika commented 7 years ago

Oh and found this one too https://github.com/mayurs142/redis-server-salt-formula (which claims to be a fork of this one, @mayurs142 any tips ?

johnkeates commented 7 years ago

It does seem like a working example, but it's somewhat old and doesn't seem to be maintained. I do use redis, but only for temporal data and haven't had the need to do it HA as my services work well without it, and a simple restart or reconfiguration fixes moest issues for us. On the other hand, I'm all for expanding formulas. If Sentinel isn't to hard to setup or orchestrate, we can probably get a MVP up and running pretty quickly, and then just have PR's and issues created on top of that.

mayurs142 commented 7 years ago

@arthurlogilab @johnkeates yes, it's a working example and customised for my environment (only Ubuntu, trusty and xenial). I was running it on an AWS cluster of 3 machines. Only things added there are, a sentinel config file and a sentinel service script. And you have to make sure that one of the machine has to be the master, where you will be pointing your slaves to. Its for first deployment only, then rest will be taken care by sentinel. And yes, it's not well maintained as I'm not using SaltStack for quite sometime now. I'll be glad to help if you face issues on it.

dseira commented 6 years ago

@arthurlogilab @johnkeates I'm working on create a state for install/config redis sentinel for ubuntu and centos. I think, at the end of this week or the next week will be release the PR.

dseira commented 6 years ago

Added support for redis sentinel in https://github.com/saltstack-formulas/redis-formula/pull/69.