search

saltstack-formulas / redis-formula

Redis state
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
40 stars 186 forks source link

fix(map): avoid `defaults.merge` bug on `salt-ssh` #77

Closed myii closed 5 years ago

myii commented 5 years ago
myii commented 5 years ago

Affecting a user in our Slack/IRC/Matrix group. Discussion from this point forward.

waynegemmell commented 5 years ago

Hi! Can someone please merge/review this? It's a blocker for me.

myii commented 5 years ago

@waynegemmell Done, I tested it out before submitting this PR so I'm confident that it's OK.

waynegemmell commented 5 years ago

@myii Fantastic, thanks!

waynegemmell commented 5 years ago

Minor issue, It needs to export redis_settings, not redis as a data structure. 

- Rendering SLS 'base:redis.common' failed: Jinja variable the template 'redis/map.jinja' (imported on line 1) does not export the requested name 'redis_settings'
myii commented 5 years ago

@waynegemmell Thanks for the catch! Fixed in #78 (merged).