search

saltstack-formulas / redis-formula

Redis state
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
40 stars 186 forks source link

[BUG] redis_disable_transparent_huge_pages runs on every highstate and reports a change #89

Open iaingeorgeson opened 3 years ago

iaingeorgeson commented 3 years ago

Your setup

Formula commit hash / release tag

v0.26.2

Versions reports (master & minion)

3002.2

Pillar / config used

In salt code: include:

In pillar: redis: disable_transparent_huge_pages: true

Bug details

Describe the bug

When redis:disable_transparent_huge_pages is set, the redis_disable_transparent_huge_pages cmd.run state runs and reports a change on every highstate.

Steps to reproduce the bug

Set aforementioned configuration. Run highstate,

Expected behaviour

Only report a change on the first run, when the configuration actually changes.

Attempts to fix the bug

Additional context

noelmcloughlin commented 3 years ago

Thanks, I raised https://github.com/saltstack-formulas/redis-formula/pull/90