search

saltstack-formulas / salt-formula

Yes, Salt can Salt itself!
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
198 stars 421 forks source link

fix(*): fix to allow deployment with salt-ssh. #432

Closed remichristiaan closed 4 years ago

remichristiaan commented 5 years ago

Basically use tplroot in sls files and pass vars used in templates through the context.

I've tested this with salt.minion successfully. Please check if you see any possible issues with this commit. I'm not able to test the other parts (yet) due to time constraints, sorry.

daks commented 5 years ago

@remichristiaan unfortunately tests are failing https://travis-ci.com/saltstack-formulas/salt-formula/jobs/231096106

remichristiaan commented 5 years ago

It seems to fail on the f_default.conf where it 'sees' the file_roots macro as a string. If I run this version with salt-ssh (py3 on ubuntu 18.04)) e.g. salt-ssh roster=scan 10.10.10.10 state.apply salt.minion it works ... so the macro is evaluated as a callable object and not as a string. I have to see if I can schedule time next week to look into this further. Are you sure the tests are okay?

daks commented 5 years ago

I didn't specifically verified, but they should because no release can be auto-generated if tests do not pass.

remichristiaan commented 4 years ago

Not relevant anymore.

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     fix(*): fix to allow deployment with salt-ssh.

Powered by Pull Assistant. Last update 34411bb ... 34411bb. Read the comment docs.