search

saltstack-formulas / salt-formula

Yes, Salt can Salt itself!
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
198 stars 421 forks source link

fix(symlinks): replace symlinks with real files #437

Closed sticky-note closed 5 years ago

sticky-note commented 5 years ago

Closes #434 .

myii commented 5 years ago

Thanks @sticky-note, all passing now. Best if we get this confirmed (and hopefully merged) from @noelmcloughlin, to ensure it's not breaking what was fixed by these symlinks.

noelmcloughlin commented 5 years ago

Would it be acceptable to rename all absent.sls to clean.sls for consistency?

myii commented 5 years ago

@noelmcloughlin That would be a breaking change for those relying on *.absent -- which is fine, if that's how we want to go. Usually, it's best to give a deprecation warning. The easier way is just to use duplicate files for the time being -- they're only small. We can fix this in the long run when moving to v1.0.0.

As I mentioned in Slack, we're already advertising salt.pkgrepo.clean in the README, which isn't currently available. @sticky-note could you add that as well, after rebasing on the latest upstream (which has the new pre-salted images, so will run much faster for you and us).

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.59.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: