search

saltstack-formulas / salt-formula

Yes, Salt can Salt itself!
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
198 stars 421 forks source link

test(pkgs_spec): update for `2019.2.1` release #438

Closed myii closed 5 years ago

myii commented 5 years ago

This is needed immediately since the Travis run fails overall without it:

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.59.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

aboe76 commented 5 years ago

@myii, this is quick, having this matrix in the salt-formula, will definitely help !!! Catching regressions early.

myii commented 5 years ago

@aboe76 It had to be done, as soon as the new packages were available in the repo, the tests started failing here! It wasn't much to do but it had to be done immediately.

myii commented 5 years ago

@aboe76 Oh, do you mean having the full matrix of 2019.2.x instances? That was only for testing this PR. Or are you suggesting that it should be used for the formula the whole time? The only problem is, we already have 8 instances selected, to try to cover the various combinations of OS and Salt version. So we're still with this matrix:

Let me know if you have any further suggestions.

aboe76 commented 5 years ago

@myii I don't think some distributions are that quick, but if we can have one distribution that's quickly with new salt releases maybe we can add that one to test early and catch maybe some regression in our formula against a newer version of salt.

myii commented 5 years ago

@aboe76 Do you have any suggestions? This first Travis run showed the distributions that had the quickest updates, i.e.:

So that's debian, ubuntu, centos and amazonlinux.

@javierbertoli has got centos-8 and 2019.2.1 pre-salted images coming out soon, so we can revisit the ordering in the matrix when that is available.