saltstack-formulas / salt-formula

Yes, Salt can Salt itself!
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
198 stars 421 forks source link

test(versions): bump salt pkg versions for travis #448

Closed noelmcloughlin closed 4 years ago

noelmcloughlin commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Bump salt package versions for Travis

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

myii commented 4 years ago

Thanks for this @noelmcloughlin. I'm just running a test across all of the instances to ensure the changes are working properly:

noelmcloughlin commented 4 years ago

Thanks @myii for doing that. I reviewed and added a commit to fix Centos. I must look at Arch but I think thats unrelated issue.

myii commented 4 years ago

@noelmcloughlin Don't worry about Arch, it's not supported by this formula. I've got a couple of suggestions that I'll be adding as a review shortly.

noelmcloughlin commented 4 years ago

it's not supported by this formula

Arch is supported (well it can work). I've been using this on Arch successfully in 2019

noelmcloughlin commented 4 years ago

've got a couple of suggestions that I'll be adding as a review shortly.

Not too many. I've been working on this formula all day (to clear the way) so done my bit ;-)

myii commented 4 years ago

@noelmcloughlin Do you mind squashing the commits into the single original commit, for semantic-release purposes, i.e.

Otherwise, I can Squash and merge using GitHub instead.

myii commented 4 years ago

test/integration/v201902-py3/controls/pkgs_spec.rb:

     when 'centos'
-      '2019.2.2-1.el8'
+      '2019.2.3-1.el8'

@noelmcloughlin I've added the above in another commit and I'll merge this once Travis is done.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.1.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: