Closed noelmcloughlin closed 4 years ago
Thanks for this @noelmcloughlin. I'm just running a test across all of the instances to ensure the changes are working properly:
Thanks @myii for doing that. I reviewed and added a commit to fix Centos. I must look at Arch but I think thats unrelated issue.
@noelmcloughlin Don't worry about Arch, it's not supported by this formula. I've got a couple of suggestions that I'll be adding as a review shortly.
it's not supported by this formula
Arch is supported (well it can work). I've been using this on Arch successfully in 2019
've got a couple of suggestions that I'll be adding as a review shortly.
Not too many. I've been working on this formula all day (to clear the way) so done my bit ;-)
@noelmcloughlin Do you mind squashing the commits into the single original commit, for semantic-release
purposes, i.e.
test(versions): bump salt pkg versions
Otherwise, I can Squash and merge
using GitHub instead.
test/integration/v201902-py3/controls/pkgs_spec.rb
:when 'centos' - '2019.2.2-1.el8' + '2019.2.3-1.el8'
@noelmcloughlin I've added the above in another commit and I'll merge this once Travis is done.
:tada: This PR is included in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Bump salt package versions for Travis
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context