saltstack-formulas / salt-formula

Yes, Salt can Salt itself!
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
197 stars 423 forks source link

Run restart master minion last #478

Closed remichristiaan closed 3 years ago

remichristiaan commented 3 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 3 years ago
Score: 0.95

Best reviewed: commit by commit


Optimal code review plan (3 warnings)

fix(*): fix to allow deployment with salt-ssh.
> `...files/minion.d/f_defaults.conf` 67% changes removed in fix(*): reverted fix... > `salt/ssh.sls` 67% changes removed in Merge branch 'master... > `salt/standalone.sls` 75% changes removed in Merge branch 'master... > `salt/cloud.sls` 75% changes removed in Merge branch 'master...
Merge branch 'master' of https://github.com/saltstack-formulas/salt-fo...
> `AUTHORS.md` 75% changes removed in Merge branch 'master... > `...1803-py2/controls/pkgs_spec.rb` 55% changes removed in Merge branch 'master... > `FORMULA` 50% changes removed in Merge branch 'master... > `...1902-py2/controls/pkgs_spec.rb` 55% changes removed in Merge branch 'master...
Merge branch 'master' of https://github.com/saltstack-formulas/salt-fo...
> `...1803-py2/controls/pkgs_spec.rb` 50% changes removed in Merge branch 'master... > `...1902-py2/controls/pkgs_spec.rb` 50% changes removed in Merge branch 'master... > `docs/AUTHORS.rst` 50% changes removed in Merge branch 'master... > `AUTHORS.md` 50% changes removed in Merge branch 'master...
     fix(*): reverted fix to allow deployment with salt-ssh.      Merge branch 'master' of https://github.com/saltstack-formulas/salt-fo...      fix(service): service `salt-master` and 'salt-minion' to (re)start las...

Powered by Pull Assistant. Last update 34411bb ... 0b65074. Read the comment docs.

remichristiaan commented 3 years ago

Something went haywire with the commits ... there should be only one.