saltstack-formulas / salt-formula

Yes, Salt can Salt itself!
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
197 stars 423 forks source link

fix(service): service salt-master and salt-minion to (re)start last. #479

Closed remichristiaan closed 3 years ago

remichristiaan commented 3 years ago

When running a high-state on the salt-master to deploy itself, the run fails with an Authentication error occurred because the master restarts half way though. When I add the order: last to the respective service. states, the high-state runs through. I do not have the time unfortunately to test this through, but at first sight it seems not to lead to problems. Thereby I cannot come up with a reason to have the master or minion restart before all the other states have finished.

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 3 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix(service): service `salt-master` and 'salt-minion' to (re)start las...

Powered by Pull Assistant. Last update c4620a0 ... c4620a0. Read the comment docs.