feat: allow selecting alternate salt package repositories

major0 commented 3 years ago

Make the upstream salt package repository selectable, thus allowing the use of archived salt versions (hosted in http://archive.repo.saltproject.io), as well as custom salt versions hosted in alternate repositories.

PR progress checklist (to be filled in by reviewers)

[X] Changes to documentation are appropriate (or tick if not required)
[X] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[X] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

myii commented 3 years ago

@major0 Thanks for the PR. You're not going to win either way, since all of the Debian/Ubuntu pkgrepo entries are using http and all of the key_url entries are using https. Let's settle on one (probably https) and just fix the tests. If you can make sure Allow edits from maintainers is allowed and I'll push the changes to complete this PR.

major0 commented 3 years ago

@major0 Thanks for the PR. You're not going to win either way, since all of the Debian/Ubuntu pkgrepo entries are using http and all of the key_url entries are using https. Let's settle on one (probably https) and just fix the tests. If you can make sure Allow edits from maintainers is allowed and I'll push the changes to complete this PR.

Allow edits is allowed.

myii commented 3 years ago

Fixed and merged (to use https), @major0 -- thanks again for the PR.

Appreciate the review, @n-rodriguez.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 1.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / salt-formula