saltstack-formulas / salt-formula

Yes, Salt can Salt itself!
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
197 stars 423 forks source link

Don't try to manage config for saltstack enterprise master plugin #500

Closed pprkut closed 2 years ago

pprkut commented 3 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

The master plugin of SaltStack Enterprise has a configuration file /etc/salt/master.d/raas. As is, the formula would delete that file on every run, since it's not managed. Managing it is IMHO outside the scope of this formula, so it should be ignored.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pprkut commented 3 years ago

The list support for exclude_pat is new in 3001, that's why the tests for 3000 are failing.

Should I wrap this in a version check for 3001 and keep the old code for older version?

myii commented 2 years ago

Thanks for the fix (and the patience), @pprkut -- approved and merged.

saltstack-formulas-travis commented 2 years ago

:tada: This PR is included in version 1.9.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: