Fix: master.d template to support saltclass ext_pillar config

[rfairburn]

PR progress checklist (to be filled in by reviewers)

• [ ] Changes to documentation are appropriate (or tick if not required)
• [ ] Changes to tests are appropriate (or tick if not required)
• [ ] Reviews completed

---

What type of PR is this?

Primary type

• [ ] [build] Changes related to the build system
• [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ ] [ci] Changes to the continuous integration configuration
• [ ] [feat] A new feature
• [x] [fix] A bug fix
• [ ] [perf] A code change that improves performance
• [ ] [refactor] A code change that neither fixes a bug nor adds a feature
• [ ] [revert] A change used to revert a previous commit
• [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [ ] [docs] Documentation changes
• [x] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

https://github.com/saltstack-formulas/salt-formula/issues/383

Describe the changes you're proposing

This allows for the default external pillar configuration for saltclass to be used. Nested lists did not accept string values previously on child ext_pillar configs.

Pillar / config required to test the proposed changes

The change to the pillar top in the test should cover this

Debug log showing how the proposed changes work

Documentation checklist

• [ ] Updated the README (e.g. Available states).
• [ ] Updated pillar.example.

Testing checklist

• [ ] Included in Kitchen (i.e. under state_top).
• [ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• [x] Updated the relevant test pillar.

Additional context

[rfairburn]

@aboe76 @myii Just wanted to check back in. Saw this sitting open for a while yet and didn't know if I needed to do anything else on this or if these normally sit open for a while before merging.

[myii]

Apologies for the delay, @rfairburn -- this has been merged.

I had to rebase, amend and force-push this PR because all the test suites were merged into one -- you'll see the changeset is a lot more simple now!

Another point to note is that using the master.d Jinja template is no longer the recommended practice with this formula. It will be removed at some point (#417). The whole discussion about this took place in this PR -- I've linked to the comment where we agreed upon using TOFS as the solution for these files.

[saltstack-formulas-travis]

:tada: This PR is included in version 1.9.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: