Open lkubb opened 2 years ago
Thanks for the PR, @lkubb. It would be great if we had MacOS testing running in the CI but we haven't got that far yet.
@noelmcloughlin Do you still have access to MacOS minions that you can test this on?
Any updates on this PR? :) Disregarding the missing root group, the issues described here can be retraced by checking the code, which cannot work as intended in its current form.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
I did not open issues for both fixes since the cause is evident.
remove-macpackage-salt
usesfile.absent
, but is referenced bysalt-minion
onchanges_in
requisite ascmd: remove-macpackage-salt
root
on MacOS:unless
requisites on two MacOS-specific states always evaluate to false, causing a reinstall on every run on MacOS. This is caused by an incorrect shell command.Describe the changes you're proposing
onchanges_in
requisite onsalt-minion
forremove-macpackage-salt
.wheel
(correction:staff
, but wheel exists at least. correction^2: It iswheel
,staff
is the admin user's primary group).unless
shell command onsalt-minion
anddownload-salt-minion
on MacOS.Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
There is no test suite for MacOS.
state_top
).Additional context