saltstack-formulas / salt-formula

Yes, Salt can Salt itself!
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
198 stars 421 forks source link

fix: master_job_cache in saltmaster jinja template #553

Open mdschmitt opened 1 year ago

mdschmitt commented 1 year ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No. This sets the default value for master_job_cache unless it's explicitly set in Pillar.

Related issues and/or pull requests

Fixes #552

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

mdschmitt commented 1 year ago

Looks like something's wrong with the current pre-commit config yml in master. I'll rebase when it's fixed.

mdschmitt commented 1 year ago

The pipeline failed, but I don't think any of the errors have to do with my PR..

mdschmitt commented 8 months ago

Hor can I make the CI retry?

dafyddj commented 8 months ago

Rebase & push

mdschmitt commented 8 months ago

Well, I re-ran the CI and it failed again, but same as last time, I don't think the failures have anything to do with my code...

mdschmitt commented 4 months ago

8 months guys. Please? It's soooo simple.

mdschmitt commented 1 month ago

welp, it's been a year since I opened this. I just rebased again and it looks like the CI still fails, but is still not (afaict) related to my PR.