Open mlalpho opened 10 months ago
[build]
[chore]
[ci]
[feat]
[fix]
[perf]
[refactor]
[revert]
[style]
[docs]
[test]
BREAKING CHANGE
No.
Fix for #541 i.e. not setting user/group on windows
README
Available states
pillar.example
state_top
Does this help with #541 ? I don't have any windows minions to test. Figured this might be a quick workaround.
Cheers!
cc @TheBigBear
@mlalpho thank you so much. clever and reading the fix this makes sense. will try this ASAP and report back expect to know for sure by early next week.
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Fix for #541 i.e. not setting user/group on windows
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context
Does this help with #541 ? I don't have any windows minions to test. Figured this might be a quick workaround.
Cheers!
cc @TheBigBear