saltstack-formulas / salt-formula

Yes, Salt can Salt itself!
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
197 stars 423 forks source link

fix(suse): update pygit2 package name #555

Open tacerus opened 9 months ago

tacerus commented 9 months ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Update package name to resolve Package 'python-pygit2' not found..

Pillar / config required to test the proposed changes

n/a

Debug log showing how the proposed changes work

n/a

Documentation checklist

Testing checklist

Additional context

tacerus commented 9 months ago

The pre-commit error does not sound like related to my changes?

denyka commented 6 months ago

You can use a construction in your pillar like

salt:
    lookup:
      pygit2: python3-pygit2
      python_git: python3-gitpython

to solve the problem like with the missing package

tacerus commented 6 months ago

Thank you, @denyka. That's useful. It would however still be great to have it repaired in the formula code, as the old packages (Python 2) no longer exist.