saltstack-formulas / salt-formula

Yes, Salt can Salt itself!
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
197 stars 423 forks source link

fix(repos): fix namings after salt binaries and keys move #561

Open sticky-note opened 5 months ago

sticky-note commented 5 months ago

BREAKING CHANGES: This commit changes upstream repository naming conventions to get latest binaries and keys. If you depends on versions of salt from older, please stick with version 1.x.x of this formula

Fixup of some requested changes from https://github.com/saltstack-formulas/salt-formula/pull/548 as we need this to work in order to unbreak formula for new versions of Salt

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

Yes

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

lelutin commented 4 months ago

Thanks @sticky-note for tackling the problems with the move of the repo key. The current code on the master branch is not working properly because of this.

I don't feel qualified to add feedback on the code changes as a whole though since there are more changes than what I would currently use.

primechuck commented 3 months ago

I was starting a PR for this, but saw yours which is much more inclusive. Any additional changes for this so we don't have to override pillar data to get salt to deploy salt?