Open sticky-note opened 5 months ago
Thanks @sticky-note for tackling the problems with the move of the repo key. The current code on the master branch is not working properly because of this.
I don't feel qualified to add feedback on the code changes as a whole though since there are more changes than what I would currently use.
I was starting a PR for this, but saw yours which is much more inclusive. Any additional changes for this so we don't have to override pillar data to get salt to deploy salt?
BREAKING CHANGES: This commit changes upstream repository naming conventions to get latest binaries and keys. If you depends on versions of salt from older, please stick with version 1.x.x of this formula
Fixup of some requested changes from https://github.com/saltstack-formulas/salt-formula/pull/548 as we need this to work in order to unbreak formula for new versions of Salt
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?Yes
Related issues and/or pull requests
Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context