search

saltstack-formulas / shorewall-formula

Saltstack formula for managing shorewall
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
5 stars 21 forks source link

shorewall version not detected if shorewall is not already installed #13

Closed Sjd-Risca closed 6 years ago

Sjd-Risca commented 6 years ago

When shorewall package is not jet installed, the formula does not detect correctly the shorewall version that will be used. Because of this often incompatible files are provided.

Please see the proposed patch.

Thanks.

Sjd-Risca commented 6 years ago

Description: running formula against a minion with shorewall not already installed. At first run is installed a rules file with the older (and incompatible) headers. Only at second run, as shorewall package is already present on system, the header are change to version 4.6 mode (?SECTION NEW ?SECTION ALL)...

n-rodriguez commented 6 years ago

Fixed by : https://github.com/saltstack-formulas/shorewall-formula/commit/5eb27ba5ef4b8aa927ae4600fdf17850c15d9652