Dynamically generated params with mine

[daks]

Hello,

this MR propose a solution to be able to generate Shorewall params with a dynamic query to Salt Mine #12. Using pillar, you can specify which salt mine query you want, and also a default value, if this query returns no results.

The mine query can return a list of IP addresses, a list of lists of IPs, or a combination of those two formats and it'll be managed by the code.

[daks]

Did anyone had the possibility to verify this MR? It works well for us in production since several weeks.

[aboe76]

@daks I don't use shorewall, on my machines...

[daks]

@aboe76 ok, so who can at least review it, and maybe then merge it? I think this functionnality is potentially interesting for many people.

[aboe76]

@puneetk could you take a look and review the code?

[daks]

any news?

[daks]

ping

[daks]

Hi,

is there anyone which can look at this pull request, and merge it if it's ok?

The code:

• runs in production since several weeks,
• has no impact if you don't use it,
• can be useful for many people,
• and it's standing in this PR from more than two months...

[n-rodriguez]

ping @puneetk

[daks]

This pull request is standing here for 4 months. Is there any chance someone with commit rights will look at it?

[aboe76]

@daks will merge it for you

[daks]

thanks