saltstack-formulas / shorewall-formula

Saltstack formula for managing shorewall
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
5 stars 21 forks source link

fix: add missing section in pillar.example #21

Closed carinedengler closed 2 years ago

carinedengler commented 2 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Not a "bug" fix per se, but the current pillar.example's rules section does reflect the state's behavior. The code iterates over the available sections, but since there are none in the example, the rules are not taken into account when the corresponding file is created.

Documentation checklist

Testing checklist

A bit unsure how to add this to the tests. Maybe you could give me a hand?

myii commented 2 years ago

Merged, thanks for this fix, @carinedengler.

carinedengler commented 2 years ago

Merged, thanks for this fix, @carinedengler.

with pleasure, thank you for this formula!