search

saltstack-formulas / shorewall-formula

Saltstack formula for managing shorewall
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
5 stars 21 forks source link

Fix rules.jinja template #4

Closed borutmrak closed 6 years ago

borutmrak commented 9 years ago

At least on Ubuntu 14.04 (Shorewall 4.5.21.6) the correct syntax is:

SECTION ALL SECTION ESTABLISHED ...

not

?SECTION ALL ?SECTION ESTABLISHED ...

Maybe this depends on the version of shorewall and it needs more work?

borutmrak commented 9 years ago

I see now that Shorewall 4.6 changed syntax in this regard. How should I go about making this dependant on the shorewall version? I want to use this formula on older shorewall for years to come (that is until Ubuntu 14.04 is out of support :)

Sjd-Risca commented 8 years ago

Fixed by https://github.com/saltstack-formulas/shorewall-formula/pull/5

Sjd-Risca commented 6 years ago

This pull request is no more required.

Could it be marked as closed?

(@puneetk, @babilen)

borutmrak commented 6 years ago

Since I never properly fixed it and it seems the older versions of Shorewall are now supported... yes.