search

saltstack-formulas / shorewall-formula

Saltstack formula for managing shorewall
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
5 stars 21 forks source link

file.managed mode should be '0644' instead of 0644 #8

Closed Talkless closed 8 years ago

Talkless commented 8 years ago

Looking ant YAML Idiosyncrasies Salt documentation, 0644 will be interpreted as octal and becomes 420.

salt.states.file always use '0644' or 644 in their examples.

wwentland commented 8 years ago

It should indeed, good catch! I'd happily merge a PR if you would be interested in creating one. If not, let me know as well.

Which file and state does this concern, btw?

Talkless commented 8 years ago

I was thinking about PR, but it's such a small change I figured maybe creator could fix it right up :-)

wwentland commented 8 years ago

Everybody would create a PR so that it can be merged by someone else. We try to avoid direct pushes so that somebody else looks over the changes.

Talkless commented 8 years ago

OK I'll make PR this evening.

Talkless commented 8 years ago

Implemented in PR #10