search

saltstack-formulas / snmp-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
17 stars 49 forks source link

[BUG] Location is quoted #38

Closed geoffjukes closed 3 years ago

geoffjukes commented 4 years ago

Line 19 and 20 in files/snmpd.conf.minimal forcefully adds quotes around the strings: (edit: ditto for lines 186 & 187 of files/snmpd.conf)

syslocation "{{ conf.get('location', 'Unknown (add saltstack pillar)') }}"
syscontact "{{ conf.get('syscontact', 'Root <root@localhost> (add saltstack pillar)') }}"

This results in a Location string of "Someplace" as opposed to the desired Someplace. Is there a reason for this?

When setting the location in other SNMP devices, the Location string is unquoted, and so this creates 2 separate grouping in our monitoring system.

myii commented 4 years ago

@geoffjukes Thanks for the report. Both of these lines were introduced around 5 years ago:

Looking at the manpage for snmpd.examples, it appears that these need to be updated to remove the quotes.

Would you care to tackle this in a PR?

CC: @alxwr.

myii commented 4 years ago

@geoffjukes ... and now I realise you've already submitted the fix in #39! Thanks for that and let's continue the discussions there instead.

ixs commented 3 years ago

Closing the bug, the PR #39 got merged. Again, thanks for your report and the PR @geoffjukes.