myii
commented
4 years ago Closes #38.
Quoting my reply from there:
Both of these lines were introduced around 5 years ago:
Looking at the manpage for snmpd.examples, it appears that these need to be updated to remove the quotes.
Hence, this proposal appears correct to me.
CC: @alxwr.
ixs
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
syslocationandsyscontactvalues are reported verbatim. When quoted, this includes the quotes.For example,
syslocation "Timbuktu"reports as"Timbuktu"whenTimbuktuis the expected/desired value.Pillar / config required to test the proposed changes
None
Debug log showing how the proposed changes work
None
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context