Closed alxwr closed 2 years ago
This popped up when I deployed on an Arch-based system.
[build]
[chore]
[ci]
[feat]
[fix]
[perf]
[refactor]
[revert]
[style]
[docs]
[test]
BREAKING CHANGE
No.
None.
map.jinja defaulted to RedHat when the os_family was not recognized. This messed up the configuration on Arch.
map.jinja
os_family
Have an Arch system?
Can't show anything here. My goal was to avoid the inclusion of the key "options" into the snmp hash.
snmp
README
Available states
pillar.example
state_top
Yes, this formula needs modernization. Yes, I'd love to see this one tested via Kitchen CI. :-)
Sadly I haven't got the time to do that now. (Maybe in the future.)
Merged, thanks for the fix, @alxwr.
Thanks for the quick merge @myii !
This popped up when I deployed on an Arch-based system.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
None.
Describe the changes you're proposing
map.jinja
defaulted to RedHat when theos_family
was not recognized. This messed up the configuration on Arch.Pillar / config required to test the proposed changes
Have an Arch system?
Debug log showing how the proposed changes work
Can't show anything here. My goal was to avoid the inclusion of the key "options" into the
snmp
hash.Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context
Yes, this formula needs modernization. Yes, I'd love to see this one tested via Kitchen CI. :-)
Sadly I haven't got the time to do that now. (Maybe in the future.)