saltstack-formulas / snmp-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
17 stars 49 forks source link

Don't default to RedHat #42

Closed alxwr closed 2 years ago

alxwr commented 2 years ago

This popped up when I deployed on an Arch-based system.

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

None.

Describe the changes you're proposing

map.jinja defaulted to RedHat when the os_family was not recognized. This messed up the configuration on Arch.

Pillar / config required to test the proposed changes

Have an Arch system?

Debug log showing how the proposed changes work

Can't show anything here. My goal was to avoid the inclusion of the key "options" into the snmp hash.

Documentation checklist

Testing checklist

Additional context

Yes, this formula needs modernization. Yes, I'd love to see this one tested via Kitchen CI. :-)

Sadly I haven't got the time to do that now. (Maybe in the future.)

myii commented 2 years ago

Merged, thanks for the fix, @alxwr.

alxwr commented 2 years ago

Thanks for the quick merge @myii !