search

saltstack-formulas / snmp-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
17 stars 49 forks source link

Add debian support #5

Closed keesbos closed 9 years ago

keesbos commented 9 years ago

Hi,

I've added limited debian support (left out /etc/default/snmpd support). Furthermore I made the config generation a bit more like ntp.ng, where the entire configuration can be created/defined from within the pillar. (See end of files/snmpd.conf and 'settings' in pillar example)

Kees

keesbos commented 9 years ago

Now I added support for /etc/default/snmpd (Debian family), which is comparable to the combined /etc/sysconfig/snmpd /etc/sysconfig/snmptrapd on RedHat.

whiteinge commented 9 years ago

@keesbos at quick glance most your changes look good.

Will you please switch the map.jinja file back to not containing a lookup dictionary to match the other formulas? The convention is to have an optional dictionary within pillar with that name that can override any of the values in the map file. The lookup dictionary shouldn't be referenced directly except once at the bottom of the map file.

keesbos commented 9 years ago

I've removed the lookup from the map.jinja. BTW It looks to me that the 'lookup' in map.jinja is the new way to do it. Three formulas have it as next generation (ng). See e.g.:

php-formula/php/ng/map.jinja
{% set php = salt['pillar.get']('php:ng', {
    'lookup': salt['grains.filter_by']({
        'Debian': {

ntp-formula/ntp/ng/map.jinja
{% set ntp = {
    'lookup': salt['grains.filter_by']({
        'Debian': {

nginx-formula/nginx/ng/map.jinja
{% set nginx = salt['pillar.get']('nginx:ng', {
    'lookup': salt['grains.filter_by']({ 
        'Debian': {

Personally, I don't have a preference :-)

whiteinge commented 9 years ago

Thanks for updating that and also for the additions!

Those three 'ng' formulas are all by the same person. I'll give that pattern another look.