Map.jinja refactoring

[daks]

PR progress checklist (to be filled in by reviewers)

• [ ] Changes to documentation are appropriate (or tick if not required)
• [ ] Changes to tests are appropriate (or tick if not required)
• [ ] Reviews completed

---

What type of PR is this?

A refactoring PR to make map.jinja use in line with latest standards from template-formula

Primary type

• [ ] [build] Changes related to the build system
• [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ ] [ci] Changes to the continuous integration configuration
• [ ] [feat] A new feature
• [ ] [fix] A bug fix
• [ ] [perf] A code change that improves performance
• [X] [refactor] A code change that neither fixes a bug nor adds a feature
• [ ] [revert] A change used to revert a previous commit
• [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

None

• [ ] [docs] Documentation changes
• [ ] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

• move data which was in the old map.jinja to defaults.yaml and other *.yaml files
• change all code to not call pillar.get but use the maps

Documentation checklist

• [ ] Updated the README (e.g. Available states).
• [ ] Updated pillar.example.

Testing checklist

• [ ] Included in Kitchen (i.e. under state_top).
• [X] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• [ ] Updated the relevant test pillar.

Additional context

[pull-assistant[bot]]

Best reviewed: commit by commit

---

Optimal code review plan

     refactor: convert map.jinja to new standards      refactor: change pillar calls

Powered by Pull Assistant. Last update ee173b0 ... d5002c3. Read the comment docs.

[daks]

Updated mapdata, let's see if tests pass.

[myii]

@daks Thanks for this. Once I finalise our YAML-based developments as discussed in Slack today, I'll push a PR here for that.

[saltstack-formulas-travis]

:tada: This PR is included in version 0.23.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: