saltstack-formulas / sudoers-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
41 stars 168 forks source link

New feature to purge included dir #66

Closed daks closed 3 years ago

daks commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

65 must be merged first

Describe the changes you're proposing

Pillar / config required to test the proposed changes

sudoers:
  purge_includedir: true

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

To add this to tests, I need to setup a complete new test suite. Not sure it's worth it.

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     refactor: convert map.jinja to new standards      refactor: change pillar calls      feat: implement option to purge included files directory

Powered by Pull Assistant. Last update 764bbb5 ... 953587e. Read the comment docs.

daks commented 3 years ago

@aboe76 I had totally forgot this PR: it's now rebased and tests are OK

myii commented 3 years ago

Nice work, @daks -- we got there eventually! Thanks for the review, @aboe76.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 0.23.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: