saltstack-formulas / sudoers-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
41 stars 166 forks source link

test(map): verify `map.jinja` dump using `_mapdata` state #68

Closed myii closed 4 years ago

myii commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ci(kitchen+travis): use latest pre-salted images      test(map): verify `map.jinja` dump using `_mapdata` state

Powered by Pull Assistant. Last update cd29502 ... 63865a2. Read the comment docs.

myii commented 4 years ago

@daks Are you OK with this being merged before #65?

daks commented 4 years ago

Yes of course. Then I'll update the mapdatas in #65

myii commented 4 years ago

Merged, thanks for confirming @daks.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.22.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: