Closed myii closed 3 years ago
Best reviewed: commit by commit
Powered by Pull Assistant. Last update 570730a ... 570730a. Read the comment docs.
@daks Realised I could use it
rather than introducing a top-level key:
Then it was a matter of figuring out how to grab the params
, which I found here:
Good job @myii :) At a side note, I recently upgraded to Inspec4 and we use the inputs
(https://docs.chef.io/inspec/inputs/) which may also be a solution to provide data to inspec. Not sure if it could be used instead of this solution and if that would be more or less convenient or powerful.
Repurposed this PR with all of the standardisations worked out across the various formulas.
Self-merging since tests only.
:tada: This PR is included in version 0.23.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
UPDATE:
~https://github.com/saltstack-formulas/sudoers-formula/pull/65#issuecomment-681046505~ ~https://github.com/saltstack-formulas/openssh-formula/pull/193~
Describe the changes you're proposing
Discussion in Slack: https://freenode.logbot.info/saltstack-formulas/20200826#c4886021-c4887283.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context