saltstack-formulas / sudoers-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
41 stars 168 forks source link

test(map): standardise `map.jinja` verification #69

Closed myii closed 3 years ago

myii commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

UPDATE:

~https://github.com/saltstack-formulas/sudoers-formula/pull/65#issuecomment-681046505~ ~https://github.com/saltstack-formulas/openssh-formula/pull/193~

Describe the changes you're proposing

Discussion in Slack: https://freenode.logbot.info/saltstack-formulas/20200826#c4886021-c4887283.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     test(_mapdata_spec): perform comparison using `describe yaml` instead

Powered by Pull Assistant. Last update 570730a ... 570730a. Read the comment docs.

myii commented 4 years ago

@daks Realised I could use it rather than introducing a top-level key:

Then it was a matter of figuring out how to grab the params, which I found here:

daks commented 4 years ago

Good job @myii :) At a side note, I recently upgraded to Inspec4 and we use the inputs (https://docs.chef.io/inspec/inputs/) which may also be a solution to provide data to inspec. Not sure if it could be used instead of this solution and if that would be more or less convenient or powerful.

myii commented 3 years ago

Repurposed this PR with all of the standardisations worked out across the various formulas.

myii commented 3 years ago

Self-merging since tests only.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 0.23.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: