Closed rokka-n closed 9 years ago
The default in config.sls is a string but the Pillar example is a boolean. The Pillar example should be changed to be a string instead.
Thanks, Nitin!
On Sat, Nov 8, 2014, 11:23 Nitin Madhok notifications@github.com wrote:
Closed #6 https://github.com/saltstack-formulas/sysstat-formula/issues/6 via f876a97 https://github.com/saltstack-formulas/sysstat-formula/commit/f876a977d62f4c14bd8788e4477382341df90532 .
— Reply to this email directly or view it on GitHub https://github.com/saltstack-formulas/sysstat-formula/issues/6#event-190357190 .
Thanks!
I think one additional change in config.sls is required so state from pillar correctly set as string as well.
sysstat-config:
file.managed:
- name: {{ sysstat.config }}
- source: salt://sysstat/sysstat.default
- mode: 644
- user: root
- group: root
- template: jinja
- defaults:
#enabled: "true"
enabled: "{{ enabled }}"```
@whiteinge No problem! @rokka-n Did you try the formula with the changes i made?
Yes, with quotes it works correctly.
@rokka-n I meant does the formula work in it's present state or enabled: {{ enabled }}
needs to be changed to enabled: "{{ enabled }}"
It has to be changed to have quotes, otherwise you'll get boolean True
@rokka-n Done! Can you please test again?
Well, it might be Ubuntu's own way of doing things, but they require "true" in /etc/default/sysstat
config.sls will set it as "True", which is a huge mistake from Ubuntu's prospective. https://github.com/saltstack-formulas/sysstat-formula/blob/master/sysstat/config.sls
Is there a way to satisfy Ubuntu's requirements to use only lowercase in the config options of /etc/default/sysstat?