Make the formula fully pillar driven/customizable

[puneetk]

Summary

• split package,config and service into separate state files
• use defaults.yml to specify all configurable options of the formula
• setup map.jinja to read in defaults.yml, filter by os_family for Redhat, and merge in sysstat:lookup pillar
• Updated README

I have moved the one sources file that was sitting in the root dir to the sources/ directory. I did this to bucket all source files, templates/otherwise in a separate directory from the state files that the formula provides.

[iggy]

I don't remember there being any discussion of changing foo-formula/foo/files to foo-formula/foo/sources, and I'm not a big fan of passing vars as context (as you end up with some complex formulas with context lists a page long) but that's just personal style. We aren't going to agree on everything.

Aside from that, it looks good.

[puneetk]

I don't remember there being any discussion of changing foo-formula/foo/files to foo-formula/foo/sources

I have moved the one sources file that was sitting in the root dir to the sources/ directory. I did this to bucket all source files, templates/otherwise in a separate directory from the state files that the formula provides. Sources as a bucket is better to represent that it the directory has templates and other files. Also sources doesn't interfere with tab completion when working in the formula dir.

I'm not a big fan of passing vars as context (as you end up with some complex formulas with context lists a page long)

I prefer it this way for separation of purpose, the state files use the settings passed form the map.jinja and any other logic and setup variables, and then template files are logic free.

[iggy]

My comment wasn't about why you moved the file. It was why you chose sources/ instead of the prevailing standard of other formulas and the SaltStack docs of using files/

[iggy]

Thanks muchly for fixing that.