[BUG] The shellcheck pre-commit hook installation fails - Githubissues

saltstack-formulas / template-formula

SaltStack formula template filled with dummy content

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

119 stars 85 forks source link

[BUG] The shellcheck pre-commit hook installation fails #226

Closed gonzalo-bulnes closed 3 years ago

gonzalo-bulnes commented 3 years ago

Bug details

Describe the bug

The installation of the pre-commit hooks fails with the error:

[ERROR] The hook `shellcheck` specifies `additional_dependencies` but is using language `script` which does not install an environment. Perhaps you meant to use a specific language?

Steps to reproduce the bug

Clone this repository
Install pre-commit (e.g. pip install pre-commit)
Install the pre-commit hooks
```
bin/install-hooks
```

Expected behaviour

I expect the hooks to be installed without errors.

Attempts to fix the bug

Updating the shellcheck hook from v2.1.3 to v2.1.5 (latest) fixes the issue, I'll open a PR.

saltstack-formulas-travis commented 3 years ago

:tada: This issue has been resolved in version 4.3.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: