[BUG] convert.sh script does not change gitlab-ci stuff

saltstack-formulas / template-formula

SaltStack formula template filled with dummy content

Other

119 stars 85 forks source link

Closed codeboyQ2n5ha45 closed 3 years ago

codeboyQ2n5ha45 commented 3 years ago

When you run the bin/convert.sh script to create your formula, the script does not change the 9-10:

only_branch_master_parent_repo: &only_branch_master_parent_repo
    - 'master@saltstack-formulas/template-formula'

And does not change lines 57-58:

- 'git remote add upstream
       https://gitlab.com/saltstack-formulas/template-formula.git'

It should change it to the name of your formula so that gitlab-ci runs.

myii commented 3 years ago

Thanks for the report, @codeboyQ2n5ha45. Hopefully @dafyddj or myself will fix this soon.

noelmcloughlin commented 3 years ago

Same issue with test/integration/default/controls /config.rb

myii commented 3 years ago

Also:

dafyddj commented 3 years ago

Same issue with test/integration/default/controls /config.rb

This seems unrelated to this bug, can you open another issue?

saltstack-formulas-travis commented 3 years ago

:tada: This issue has been resolved in version 5.0.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: