fix(convert-formula.sh): fix reST underlining during conversion

[dafyddj]

PR progress checklist (to be filled in by reviewers)

• [ ] Changes to documentation are appropriate (or tick if not required)
• [ ] Changes to tests are appropriate (or tick if not required)
• [ ] Reviews completed

---

What type of PR is this?

Primary type

• [ ] [build] Changes related to the build system
• [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ ] [ci] Changes to the continuous integration configuration
• [ ] [feat] A new feature
• [x] [fix] A bug fix
• [ ] [perf] A code change that improves performance
• [ ] [refactor] A code change that neither fixes a bug nor adds a feature
• [ ] [revert] A change used to revert a previous commit
• [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [ ] [docs] Documentation changes
• [ ] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

NA

Describe the changes you're proposing

Fix the conversion script so that reST section headings/underlines match the length of the new formula name.

Pillar / config required to test the proposed changes

NA

Debug log showing how the proposed changes work

$ DEBUG=true bin/convert-formula.sh my-long_name-test
...
++ repeat_char =                                                                                                                                                                                                   
++ printf %17s                                                                                           
++ tr ' ' =                                                                                              
++ repeat_char '^'                                                                                       
++ printf %17s                                                                                           
++ tr ' ' '^'                                                                                            
++ repeat_char '`'                                                                                       
++ printf %17s                                                                                           
++ tr ' ' '`'                                                                                            
+ sedi '/TEMPLATE/{                                                                                      
        n                                                                                                
        s/========/=================/                                                                    
        s/\^^^^^^^^/\^^^^^^^^^^^^^^^^^/                                                                  
        s/````````/`````````````````/                                                                    
        }' docs/README.rst docs/map.jinja.rst                                                            
+ sed --version                                                                                                                                                                                                    
+ sed -i '' '/TEMPLATE/{                                                                                 
        n                                                                                                
        s/========/=================/                                                                    
        s/\^^^^^^^^/\^^^^^^^^^^^^^^^^^/                                                                  
        s/````````/`````````````````/                                                                    
        }' docs/README.rst docs/map.jinja.rst

# Results in e.g.
$ cat docs/README.rst
...
my-long_name-test-formula
=========================
...
``my-long_name-test.package``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...

Documentation checklist

• [ ] Updated the README (e.g. Available states).
• [ ] Updated pillar.example.

Testing checklist

• [ ] Included in Kitchen (i.e. under state_top).
• [x] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• [ ] Updated the relevant test pillar.

Additional context

[myii]

@dafyddj As mentioned in Slack, this commit works for me:

• https://github.com/myii/template-formula/commit/659882aeff19397b999040745190cb5106c77b5a

[myii]

Thanks for the excellent fix, @dafyddj -- merged. @baby-gnu Thanks for the review.

[saltstack-formulas-travis]

:tada: This PR is included in version 5.0.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: