chore(gitiginore): add more ignorable artifacts - Githubissues

saltstack-formulas / template-formula

SaltStack formula template filled with dummy content

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

119 stars 85 forks source link

chore(gitiginore): add more ignorable artifacts #240

Closed noelmcloughlin closed 2 years ago

noelmcloughlin commented 2 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[x] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

This PR adds further unwanted artifacts to the gitignore list for formulas. Comments welcome.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

noelmcloughlin commented 2 years ago

Closing as getting stale.

By the way, an alternative option is to use https://github.com/github/gitignore/blob/main/Python.gitignore Or even create PR for https://github.com/github/gitignore/blob/main/Salt.gitignore and use that.