saltstack-formulas / template-formula

SaltStack formula template filled with dummy content
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
119 stars 85 forks source link

refactor(libmatchers): match default type with docs #245

Closed stasjok closed 2 years ago

stasjok commented 2 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

When I first looked at map.jinja I was having trouble to understand what is Y, because I wasn't able to find anything about it in the source code of libmapstack/libmatchers and comments didn't help. After I read the code, I understood that it doesn't matter what character to use as long as it's not C/G/I, but map.jinja uses Y, documentation uses Y, so maybe change it also in the comments?

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

baby-gnu commented 2 years ago

Thanks @stasjok

saltstack-formulas-travis commented 2 years ago

:tada: This PR is included in version 5.0.7 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

myii commented 2 years ago

Pushed out across relevant formulas using https://github.com/myii/ssf-formula/pull/418 (with author set as Stanislav Asunkin).