saltstack-formulas / template-formula

SaltStack formula template filled with dummy content
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
119 stars 85 forks source link

ci(gitlab-ci): use Node `16.x` for `pre-commit` in test conversion job #249

Closed myii closed 2 years ago

myii commented 2 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

The test_conversion job failed during the weekly testing:

The stderr being:

/root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node:
/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found
(required by /root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node)

The following references led to this resolution:

As mentioned there:

a few days ago node 18.x was released and the prebuilt binaries require a relatively-recent version of glibc

Which obviously isn't available on our current Bionic-based dind image, i.e. 'myii/ssf-dind-ruby-bionic:2.7.5-1bbox1'.

While debugging this situation locally, noticed that the use of a relative tmp/... subdirectory was within the template-formula directory itself -- so switched this to using /tmp/... instead.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

myii commented 2 years ago

Thanks for the prompt review, @dafyddj.

saltstack-formulas-travis commented 2 years ago

:tada: This PR is included in version 5.0.9 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: