[BUG] Debian family python package

saltstack-formulas / ufw-formula

Manages your firewall using ufw with pillar configured rules

Apache License 2.0

7 stars 37 forks source link

[BUG] Debian family python package #19

Closed OrangeDog closed 4 years ago

OrangeDog commented 4 years ago

On debian, this formula always tries to install python-ufw.

If running salt on python3, this package does nothing.
Latest releases (e.g. Ubuntu 20.04) don't have this package.

OrangeDog commented 4 years ago

A workaround

extend:
  ufw-package-python-ufw-install-pkg-installed:
    pkg:
      - onlyif:
        - fun: test.false

myii commented 4 years ago

Thanks, @OrangeDog -- will try to get some eyes on this soon.

myii commented 4 years ago

This is where we're currently stuck at the moment with testing on 20.04:

https://travis-ci.org/github/myii/ufw-formula/builds/692888138#L2039-L2053

OrangeDog commented 4 years ago

I tested the base ubuntu:focal image and indeed iptables seems to be broken. On a real installation it works just fine.

This issue isn't a 20.04-specific problem though, it just happens to be worse on that system because it fails completely instead of simply being useless.

myii commented 4 years ago

Switching off ipv6 has got the tests passing:

https://travis-ci.org/github/myii/ufw-formula/builds/692928709

A bit more housekeeping and a PR will be able to be proposed.

saltstack-formulas-travis commented 4 years ago

:tada: This issue has been resolved in version 0.5.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: