search

saltstack-formulas / ufw-formula

Manages your firewall using ufw with pillar configured rules
Apache License 2.0
7 stars 37 forks source link

[FEATURE] openSUSE Tumbleweed: Allow installation from security repo and enable in CI #26

Open myii opened 3 years ago

myii commented 3 years ago

Is your feature request related to a problem?

Just pushed 69b4cc5 to update to the latest pre-salted images. openSUSE Tumbleweed is the last platform that isn't working.

https://gitlab.com/myii/ufw-formula/-/jobs/1027276035

      ID: ufw-package-install-pkg-installed
Function: pkg.installed
    Name: ufw
  Result: False
 Comment: An error was encountered while installing package(s): Zypper command failure: Running scope as unit: run-rc2f70f78a2414d1498971d9307eed012.scope
   Package 'ufw' not found.

This is because the ufw package isn't available in the official repos.

https://software.opensuse.org/package/ufw

There is no official package available for openSUSE Tumbleweed

Describe the solution you'd like

Successfully tested the kitchen run locally after enabling the security repo.

https://software.opensuse.org/download.html?project=security&package=ufw

zypper addrepo https://download.opensuse.org/repositories/security/openSUSE_Tumbleweed/security.repo

Another repo available (which wasn't tested).

https://opensuse.pkgs.org/tumbleweed/security-x86_64/ufw-0.36-24.7.noarch.rpm.html

zypper addrepo https://ftp.lysator.liu.se/pub/opensuse/repositories/security/openSUSE_Tumbleweed/ security-x86_64

If a repo is provided, then this line should be uncommented as well:

https://github.com/saltstack-formulas/ufw-formula/blob/69b4cc5ff055b39f563f626ae84580b826531520/.gitlab-ci.yml#L148

@aboe76 Should this be provided by default or should this be opt-in?

Describe alternatives you've considered

Don't support it on openSUSE Tumbleweed until there's an official package made available.

Additional context

aboe76 commented 3 years ago

@myii ufw on opensuse should be opt-in, not default. Opensuse has firewalld as default since 15.x

myii commented 3 years ago

@myii ufw on opensuse should be opt-in, not default. Opensuse has firewalld as default since 15.x

Thanks for the prompt reply, @aboe76. I'll leave this issue open in case anyone wants to deal with this at some point.