feat(semantic-release): implement for this formula

saltstack-formulas / users-formula

Configure users via pillar

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

99 stars 362 forks source link

feat(semantic-release): implement for this formula #207

Closed myii closed 5 years ago

myii commented 5 years ago

Based on ssf-formula (v0.3.0)
- https://github.com/myii/ssf-formula/pull/5
Unable to use pillar.example directly for testing
- Used it as a basis for test/salt/pillar/default.sls
- Brought useful changes back to pillar.example
Fix: avoid users/googleauth.sls for RedHat & Suse
Close #203

myii commented 5 years ago

Strange, this repo isn't configured for Travis at all. I've made a request on Slack so we'll have to wait for this to be activated before merging this.

CC: @gtmanfred.

myii commented 5 years ago

Thanks for the review @noelmcloughlin.

myii commented 5 years ago

@noelmcloughlin @aboe76 Travis has been enabled for this repo and the tests pass -- probably not updating here properly since it was enabled after this PR was created. In any case, this is ready to be merged, if there aren't any concerns.

noelmcloughlin commented 5 years ago

Thanks @myii

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.47.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

myii commented 5 years ago

Thanks for the review and merge, @noelmcloughlin.